Wireshark-commits: [Wireshark-commits] master e8f6a90: SMB2: fix memleak of tids hash table
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Jan 2019 18:29:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8f6a90a85e8b8d09b2f03f948cc634da2d5222d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e8f6a90 by Peter Wu (peter@xxxxxxxxxxxxx):

    SMB2: fix memleak of tids hash table
    
    Caught by ASAN:
    
        Direct leak of 88 byte(s) in 1 object(s) allocated from:
            #0 0x564bccf83549 in malloc (run/tshark+0x1b0549)
            #1 0x7f8dd1d488d1 in g_malloc glib/glib/gmem.c:99:13
            #2 0x7f8dd1d29094 in g_slice_alloc glib/glib/gslice.c:1024:11
            #3 0x7f8dd1d64cde in g_hash_table_new_full glib/glib/ghash.c:717:16
            #4 0x7f8dde889de6 in smb2_get_session epan/dissectors/packet-smb2.c:1135:15
            #5 0x7f8dde89258e in dissect_smb2_session_setup_response epan/dissectors/packet-smb2.c:3356:16
            #6 0x7f8dde8867cd in dissect_smb2_command epan/dissectors/packet-smb2.c:9189:12
            #7 0x7f8dde87fb6e in dissect_smb2 epan/dissectors/packet-smb2.c:9543:27
    
    Change-Id: I33586e8d27263a8e546efb2ee3a3054eb9a66893
    Reviewed-on: https://code.wireshark.org/review/31702
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  8ce3450   SDP: remove unused setup_proto field to fix memleaks
     add  e8f6a90   SMB2: fix memleak of tids hash table


Summary of changes:
 epan/dissectors/packet-smb2.c | 10 +++++-----
 epan/dissectors/packet-smb2.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)