Wireshark-commits: [Wireshark-commits] master 5dd86a0: CMake: do not set RPATH when installing to a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Jan 2019 21:59:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5dd86a0a7e96239fcec3d404c035413c1eb768a8
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5dd86a0 by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: do not set RPATH when installing to a system directory
    
    When built with -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib
    (as is done by many Linux distributions), do not set an unnecessary
    RPATH. This was the case before v2.9.0rc0-2727-g697623411c.
    
    Relocatable builds will still be possible with the default options as
    /usr/local/lib is typically not considered a system library path.
    
    Change-Id: Ic6ff1760183c20d3f9f9fb787604e888e116534e
    Reviewed-on: https://code.wireshark.org/review/31602
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  91d68d2   json_dumper: increase JSON_DUMPER_MAX_DEPTH to 1100.
     add  5dd86a0   CMake: do not set RPATH when installing to a system directory


Summary of changes:
 CMakeLists.txt        | 43 +++++++++++++++++++++----------------------
 extcap/CMakeLists.txt |  5 +++--
 2 files changed, 24 insertions(+), 24 deletions(-)