Wireshark-commits: [Wireshark-commits] master d50bd39: Qt: Cleanup deletion of CopyFromProfileMenu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 Jan 2019 04:23:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d50bd39b8531ccf26385f91e2815ea4f9cc7b6c4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d50bd39 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Cleanup deletion of CopyFromProfileMenu
    
    Set the push button as parent to the profile list menu so it will
    be deleted when that parent is destroyed.
    
    Change-Id: Ide4a234e039a3e27d9ee4732a3800906c80be173
    Reviewed-on: https://code.wireshark.org/review/31446
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6739523   valgrind-wireshark: default to looking in run/ for our binaries.
     add  d50bd39   Qt: Cleanup deletion of CopyFromProfileMenu


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp          | 10 ++++------
 ui/qt/coloring_rules_dialog.h            |  2 --
 ui/qt/io_graph_dialog.cpp                | 10 ++++------
 ui/qt/io_graph_dialog.h                  |  2 --
 ui/qt/uat_dialog.cpp                     | 10 ++++------
 ui/qt/uat_dialog.h                       |  2 --
 ui/qt/uat_frame.cpp                      | 10 ++++------
 ui/qt/uat_frame.h                        |  3 ---
 ui/qt/widgets/copy_from_profile_menu.cpp |  3 ++-
 ui/qt/widgets/copy_from_profile_menu.h   |  2 +-
 10 files changed, 19 insertions(+), 35 deletions(-)