Wireshark-commits: [Wireshark-commits] master 814c57a: Pass a structure including an atm_phdr to di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 05 Jan 2019 08:19:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=814c57a8b53a0841f513fd83f367844243a6833e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

814c57a by Guy Harris (guy@xxxxxxxxxxxx):

    Pass a structure including an atm_phdr to dissect_atm_pw_oam_cell().
    
    This will allow the VPI and VCI to be handed to
    dissect_atm_cell_payload() in
    https://code.wireshark.org/review/c/31381/.
    
    That structure also needs to include the enable_fill_columns_by_atm_dissector
    flag; we remove that from the pwatm_private_data_t, which is now private
    to the ATM pseudo-wire dissector, and put it in the new structure.
    
    Change-Id: I88f4a9f4b3c4c1c94914311bb883ea38e10ca4b4
    Reviewed-on: https://code.wireshark.org/review/31384
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  40b2ba8   WSDG: update testing section to cover use of pytest
     add  814c57a   Pass a structure including an atm_phdr to dissect_atm_pw_oam_cell().


Summary of changes:
 epan/dissectors/packet-atm.c    |  4 +--
 epan/dissectors/packet-pw-atm.c | 80 +++++++++++++++++++++++++++++++++++++----
 epan/dissectors/packet-pw-atm.h | 71 ++----------------------------------
 3 files changed, 79 insertions(+), 76 deletions(-)