Wireshark-commits: [Wireshark-commits] master f100f7f: maxmind_db: Close our pipe FDs inside a lock
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 05 Jan 2019 06:46:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f100f7f122885418dfd4d65a062632c6bbdd20c7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f100f7f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    maxmind_db: Close our pipe FDs inside a lock.
    
    Lock our pipe mutex before closing its file descriptors. This should
    hopefully fix some infrequent crashes that I'm seeing on my Windows 7 VM.
    
    Add a note about GRWLock behavior on Windows which doesn't appear to be
    related to this issue, but which is nevertheless important.
    
    Ping-Bug: 14701
    Change-Id: I32e66a24258264fa65a907f319755594f90c0177
    Reviewed-on: https://code.wireshark.org/review/31375
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5fa9257   add encoding windows 1251, cp855, cp866
     add  f100f7f   maxmind_db: Close our pipe FDs inside a lock.


Summary of changes:
 epan/maxmind_db.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)