Wireshark · Wireshark-commits: [Wireshark-commits] master 22588bb: Updates and bugfixes of ASTERIX I062

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22588bb924347fd517ff757745b0f98ca781c298
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

22588bb by Atli Guðmundsson (atli@xxxxxxx):

    Updates and bugfixes of ASTERIX I062
    
    I062 v1.18 updates (now the default)
    - Updated I062/380#10.STAT, new enum values  (6 & 7)
    - Added asterix.062/080.SFC
    - Added asterix.062/080.IDD
    - Added asterix.062/080.IEC
    I062 v1.17 updates
    - Added asterix.062/060.V
    - Added asterix.062/060.G
    I062 bugfixes:
    - Fixed I062 Capitalisation inconsistencies
    - Fixed I062/080.FPLT, incorrect value mask
    - Fixed I062/080.SDS, incorrect value mask
    - Fixed I062/110#1.M5, incorrect name (was I062/110#1.MD5)
    - Fixed I062/110#4, incorrect abbreviation (was asterix.062_11_04)
    - Fixed I062/110#4, missing spare bit
    - Fixed I062/110#4.RES, incorrect value mask
    - Fixed I062/110#6, incorrect abbreviation (was asterix.062_11_06)
    - Fixed I062/136.MFL, incorrect abbreviation (was asterix.062_136_ALT)
    - Fixed I062/245.STI, was missing
    - Fixed I062/245, did not display anything
    - Fixed I062/290, incorrect abbreviation, (was asterix.062_)
    - Fixed I062/295#7.MHG, incorrect name (was I062/295#07.MHD)
    - Fixed I062/340#4/5, incorrect abbreviations (was asterix.062_340_)
    - Fixed I062/380#4, incorrect abbreviation (was asterix.062_380_4)
    - Fixed I062/380#4.IAS, incorrect scaling (depends on IM bit)
    - Fixed I062/380#6.ALT, incorrect type (was unsigned)
    - Fixed I062/380#7.ALT, incorrect type (was unsigned)
    - Fixed I062/380#9.NC, incorrect value mask
    - Fixed I062/380#9.TD, incorrect field size
    - Fixed I062/380#9.TTR, incorrect type (was signed)
    - Fixed I062/380#17.TA, incorrect type (was signed)
    - Fixed I062/380#19.VUC, incorrect field size
    - Fixed I062/390#3, incorrect type (was 32-bit), incorrect value mask
    - Fixed I062/390#n, incorrect abbreviations (was asterix.062_nn)
    - Fixed I062/500#3.APWLAT, incorrect type (was signed)
    - Fixed I062/500#3.APWLON, incorrect type (was signed)
    - Fixed I062/500#n, incorrect abbreviations (was asterix.062_nn)
    - Fixed I062/510, missing support for slaved trackers
    - Fixed I062/510.SUD, incorrect name (was I062/510.SID)
    - Fixed I062/510.SUD, incorrect type (was 24-bit), incorrect value mask
    - Fixed I062/510.STN, incorrect value mask
    - Updated I062/RE.CST.SAC/SIC, now reports as asterix.SAC/SIC
    - Updated I062/RE.CSNT.SAC/SIC, now reports as asterix.SAC/SIC
    
    Note: incorrect value masks and field sizes would in most cases
    cause an exception when trying to decode those fields.
    
    Change-Id: If6b9662d20619dd30b4fe28907ab0630c6d55e44
    Reviewed-on: https://code.wireshark.org/review/31214
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e307c70   Make dissect_icmp_extension_structure into a dissector function.
     add  22588bb   Updates and bugfixes of ASTERIX I062


Summary of changes:
 epan/dissectors/packet-asterix.c | 491 +++++++++++++++++++++++++--------------
 1 file changed, 323 insertions(+), 168 deletions(-)