Wireshark-commits: [Wireshark-commits] master b9473c4: Fix asn2wrs.py: always add BASE_VAL64_STRING
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 01 Jan 2019 14:59:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9473c46f72d7d8d931496d019f0cecb8430ff31
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b9473c4 by Christophe GUERBER (christophe.guerber@xxxxxxxxx):

    Fix asn2wrs.py: always add BASE_VAL64_STRING
    
    In some cases (e.g. when a field has a user defined dissection function)
    the type reported for this field is a 'virtual' one and the latter is not
    contained in selt.type. Consequently, BASE_VAL64_STRING is not set.
    
    Function eth_get_type_attr should return all the attributes of a type and
    it seems resonable to expect it to return the BASE_VAL64_STRING. This
    will solve the above mentioned error and may solve any possible issue in
    other parts that call this function.
    
    Change-Id: Iaee9ce5bd30f2a768cfcecf628df23bf1ed54e55
    Reviewed-on: https://code.wireshark.org/review/31287
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a05ba5b   Happy New Year 2019!
     add  b9473c4   Fix asn2wrs.py: always add BASE_VAL64_STRING


Summary of changes:
 tools/asn2wrs.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)