Wireshark · Wireshark-commits: [Wireshark-commits] master 75be002: Qt: Open our preference dialogs via "clicked" signals.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75be0027d0a0c2e385ef318d677becb9a850c104
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

75be002 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Open our preference dialogs via "clicked" signals.
    
    In ModulePreferencesScrollArea we create QPushButtons that open modal
    UAT and file dialogs. Open them via the "clicked" signal instead of
    the "pressed" signal. "clicked" is a general activation signal that
    fires after the mouse button has been clicked+released or a keyboard
    event. "pressed" fires before "released" and can be problematic in
    some cases.
    
    Bug: 15366
    Change-Id: Icb353d86ae0a4b4b97e5f63df791ec562070756d
    Reviewed-on: https://code.wireshark.org/review/31123
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  003cba9   Thrift: Update to use guint32 for iterator to eliminate cast
     add  75be002   Qt: Open our preference dialogs via "clicked" signals.


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp | 16 ++++++++--------
 ui/qt/module_preferences_scroll_area.h   |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)