Wireshark-commits: [Wireshark-commits] master c0a2844: Provide data to inner dissector for PER open
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Dec 2018 09:25:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0a28448a57ca67892fdcd5c3fbc2d6f0182e310
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c0a2844 by Christophe GUERBER (christophe.guerber@xxxxxxxxx):

    Provide data to inner dissector for PER open type
    
    When an open type is decoded in ASN.1 PER, one can define a dissector
    for the content of the open type. Providing data to the inner dissector
    is only possible through packet info private data or global vars.
    
    Use the private_data field from ASN.1 context as the data for the inner
    dissector. This avoids using packet info private data to communicate
    with the inner dissector, especially if the data to be provided are only
    "local" matter.
    
    Ping-Bug: 15148
    Change-Id: I8fd2cb69d52e371e7d713afe2cc4b2856fb39f7c
    Reviewed-on: https://code.wireshark.org/review/31087
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6556f37   Added AVPs: Idle-To-Connected-Transition-Count and Connected-Duration
     add  c0a2844   Provide data to inner dissector for PER open type


Summary of changes:
 epan/dissectors/packet-per.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)