Wireshark-commits: [Wireshark-commits] master 3d90bb3: UI: Make sure we always have interface stati
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Dec 2018 18:35:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d90bb3a7c762329d5ea18bc8d86325ab9f7413b
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3d90bb3 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    UI: Make sure we always have interface statistics.
    
    Ensure that capture_stat_start always returns a non-NULL if_stat_cache_t
    pointer. This keeps InterfaceTreeModel::updateStatistic from repeatedly
    running dumpcap when we're unable to gather statistics, e.g. when we
    don't have capture permissions.
    
    Bug: 14284
    Change-Id: Id408714a934abab2abdee1d4bb5e4bed872af016
    Reviewed-on: https://code.wireshark.org/review/31038
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d9a201d   PFCP: Calculate the length of Network Instance.
     add  3d90bb3   UI: Make sure we always have interface statistics.


Summary of changes:
 ui/capture.c                          | 15 +++++++++------
 ui/capture.h                          |  2 +-
 ui/qt/models/interface_tree_model.cpp |  5 +----
 3 files changed, 11 insertions(+), 11 deletions(-)