Wireshark-commits: [Wireshark-commits] master 11c4b31: CIP: Show more unparsed data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Dec 2018 04:42:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11c4b31fc934f365eec9eab3310676a586bb9102
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

11c4b31 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP: Show more unparsed data
    
    Extra data could be an indicator of a problem, or it could be that we
    haven't added support in Wireshark for it yet. Either way, it's helpful
    to show it, instead of hiding it.
    
    Changes:
    1. Show unparsed data in the CIP CM dissector
    2. Clean up some offsets
    
    Change-Id: Ieebe208aab1f293f97a8774a6a4de5d5dbd3df67
    Reviewed-on: https://code.wireshark.org/review/31003
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3757db3   ENIP: Add more error checking
     add  11c4b31   CIP: Show more unparsed data


Summary of changes:
 epan/dissectors/packet-cip.c | 78 +++++++++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 34 deletions(-)