Wireshark-commits: [Wireshark-commits] master f7def1d: Revert "CMake: Fix Windows help install targ
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Dec 2018 02:01:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7def1d07f39c8b90245a20d09a4b56ae23de077
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f7def1d by Peter Wu (peter@xxxxxxxxxxxxx):

    Revert "CMake: Fix Windows help install target"
    
    This reverts commit 8992760c68f3e508a0e5a25307c246a75f7c2ae2.
    
    Breaks the "make clean" target as it tries to remove the "help"
    directory. Since this change, the macOS builds started failing tests as
    well (init.lua and colorfilters seems not to be applied).
    
    Change-Id: I3fce346e04875e667680a4ed9ba3beca8054a168
    Reviewed-on: https://code.wireshark.org/review/30950
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  ceef87c   CMake: limit -Wextra-semi to C++ only
     add  f7def1d   Revert "CMake: Fix Windows help install target"


Summary of changes:
 CMakeLists.txt      | 97 +++++++++++++++++++++++++++++++++++++++++------------
 help/CMakeLists.txt | 65 -----------------------------------
 2 files changed, 75 insertions(+), 87 deletions(-)
 delete mode 100644 help/CMakeLists.txt