Wireshark-commits: [Wireshark-commits] master 13e3063: couchbase: Update FlexFrame dissector to inc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Dec 2018 06:05:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13e3063848e1f5cd25f3f6c6f307ee13d5231695
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

13e3063 by Jim Walker (jim@xxxxxxxxxxxxx):

    couchbase: Update FlexFrame dissector to include requests
    
    Update the couchbase packet dissector with some re-factoring of the
    FlexFrame dissector and then extra functionality for:
    
    * FlexFrame on requests (magic 0x08)
    * Durability
    * Out-Of-Order requests
    * DCP Stream ID
    
    Additional checks are added to warn/error for invalid frame lengths and
    for the case where the FlexFrame byte0 is 0xff, which is not defined by
    the protocol.
    
    Change-Id: I5f1fec8293284dadbdef717d02fa1eef27da7a0c
    Reviewed-on: https://code.wireshark.org/review/30894
    Reviewed-by: Dave Rigby <daver@xxxxxxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e19086b   Clean up memory allocation
     add  13e3063   couchbase: Update FlexFrame dissector to include requests


Summary of changes:
 epan/dissectors/packet-couchbase.c | 353 ++++++++++++++++++++++++++++---------
 1 file changed, 267 insertions(+), 86 deletions(-)