Wireshark-commits: [Wireshark-commits] master 97dbdc3: TLS: really delay key lookup until it is nec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 01 Dec 2018 09:08:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97dbdc3ac9ae55ed0932d42dca73e07ee0aa3ffd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

97dbdc3 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: really delay key lookup until it is necessary
    
    Even if the certificate has a RSA public key, be sure to lookup the key
    only if it is an actual RSA key exchange. Move the hashtable to the
    secrets module to enable reuse.
    
    Change-Id: I39010831079d3b65d5d4368ec97d02491c1615a5
    Reviewed-on: https://code.wireshark.org/review/30854
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0ceead5   CMake: Avoid link_directories()
     add  97dbdc3   TLS: really delay key lookup until it is necessary


Summary of changes:
 epan/dissectors/packet-dtls.c      |  4 +--
 epan/dissectors/packet-tls-utils.c | 61 ++++++++++++--------------------------
 epan/dissectors/packet-tls-utils.h | 17 ++---------
 epan/dissectors/packet-tls.c       |  3 +-
 epan/secrets.c                     | 36 ++++++++++++++++++++++
 epan/secrets.h                     | 15 ++++++++++
 6 files changed, 76 insertions(+), 60 deletions(-)