Wireshark-commits: [Wireshark-commits] master 9c0beaf: Fixes AODV packet dissector for flags in RRE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Nov 2018 05:11:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c0beafe44480b352bb4af56754143c9108a54fa
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9c0beaf by Christophe GUERBER (christophe.guerber@xxxxxxxxx):

    Fixes AODV packet dissector for flags in RREQ, RREP and RERR
    
    Dissector code added flag values in the flag branch label.
    Values should be added by proto_tree_add_bitmask.
    Individual flags were all '0' when expanding the branch
    in the packet details window.
    
    Use proto_tree_add_bitmask_with_flags instead and correct
    flags values and length (as in packet-ip.c). Remove flag
    values adding to label "by hand" and remove unused local vars.
    
    Change-Id: Id5bc63d2e1a0453664d21f554f0f3b8c36d7263f
    Reviewed-on: https://code.wireshark.org/review/30835
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9bc4513   debian-setup: accept GnuTLS 3.2.11 on Ubuntu 14.04 for Travis
     add  9c0beaf   Fixes AODV packet dissector for flags in RREQ, RREP and RERR


Summary of changes:
 epan/dissectors/packet-aodv.c | 73 +++++++++++++++----------------------------
 1 file changed, 25 insertions(+), 48 deletions(-)