Wireshark-commits: [Wireshark-commits] master e12753d: TDS: Fix decoding of TDS7 password.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Nov 2018 06:21:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e12753d5f6e6f474af9934e8102cb4190aaa5846
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e12753d by Craig Jackson (cejackson51@xxxxxxxxx):

    TDS: Fix decoding of TDS7 password.
    
    Fix decoding of the TDS7 password field by treating it as a byte string, not an ASCII string.
    
    Also fix another display problem demonstrated by the sample trace.
    
    Bug: 15274
    Change-Id: I906d6e9499e2e986820e9248604e98051d877bed
    Reviewed-on: https://code.wireshark.org/review/30653
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4e17bd6   Use the dump parameters structure for non-pcapng-specific stuff.
     add  e12753d   TDS: Fix decoding of TDS7 password.


Summary of changes:
 epan/dissectors/packet-tds.c | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)