Wireshark-commits: [Wireshark-commits] master 5d7199d: PKIX1EXPLICIT: Fixing Attribute and Attribut
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Nov 2018 17:58:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d7199d8cedc31d5bb24d9f5c25aa9c4dab80669
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5d7199d by Martin Peylo (wireshark@xxxxxxx):

    PKIX1EXPLICIT: Fixing Attribute and AttributeTypeAndValue ASN.1 cnf
    
    EXPERIMENTAL, this has not been widely validated yet.  It is not clear whether
    there is any deeper sense in how the prior ASN.1 cnf was done.
    
    If this is used, it might also be beneficial to rename the double-overloaded
    "type".
    
    Removing pre-existing empty line at the end of packet-pkix1explicit-template.c
    to comply with coding style requirements.
    
    Change-Id: Iaddeb62f8abb8605b182091ea9c64b8f2172a884
    Reviewed-on: https://code.wireshark.org/review/30599
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0142ca4   PKCS10/pkix1explict: adding PKCS#9 OIDs
     add  5d7199d   PKIX1EXPLICIT: Fixing Attribute and AttributeTypeAndValue ASN.1 cnf


Summary of changes:
 .../pkix1explicit/packet-pkix1explicit-template.c  |  1 -
 .../asn1/pkix1explicit/pkix1explicit.cnf           | 12 ++----
 epan/dissectors/packet-pkix1explicit.c             | 47 +++++++++++++---------
 3 files changed, 32 insertions(+), 28 deletions(-)