Wireshark-commits: [Wireshark-commits] master 11a9a50: Dumpcap+Qt: Add support for `-a packets:NUM`
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11a9a501fb004bd3259f457714670ffb6d3d21e9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
11a9a50 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Dumpcap+Qt: Add support for `-a packets:NUM` and `-b packets:NUM`.
Add the ability to rotate files after a specified number of packets (`-b
packets:NUM`). Move some condition checks to capture_loop_write_packet_cb.
Add `-a packets:NUM` in order to be consistent. It is functionally
equivalent to the `-c` flag.
Add a corresponding "packets" option to the Capture Interfaces dialog
Output tab.
Add initial tests for autostop and ringbuffer conditions.
Change-Id: I66eb968927ed287deb8edb96db96d7c73526c257
Reviewed-on: https://code.wireshark.org/review/30534
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 9b6b36b isakmp: Free the UAT tables' records using a free callback
add 11a9a50 Dumpcap+Qt: Add support for `-a packets:NUM` and `-b packets:NUM`.
Summary of changes:
capchild/capture_sync.c | 39 ++++++-----
capture_opts.c | 10 +++
capture_opts.h | 5 +-
doc/dumpcap.pod | 24 ++++---
doc/tshark.pod | 25 ++++---
doc/wireshark.pod.template | 24 ++++---
docbook/release-notes.asciidoc | 1 +
dumpcap.c | 133 +++++++++++++++++++-----------------
test/suite_capture.py | 108 +++++++++++++++++++++++++++--
test/util_dump_dhcp_pcap.py | 11 ++-
ui/qt/capture_interfaces_dialog.cpp | 15 +++-
ui/qt/capture_interfaces_dialog.ui | 120 ++++++++++++++++++++------------
12 files changed, 348 insertions(+), 167 deletions(-)
