Wireshark-commits: [Wireshark-commits] master-2.6 a27b695: wsutil: introduce ws_pipe_close() helper
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 01 Nov 2018 09:46:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a27b695b3b09d353a86cb7a0d77530b0db68ebae
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

a27b695 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    wsutil: introduce ws_pipe_close() helper and use it to terminate mmdbresolve
    
    We were not calling TerminateProcess() to stop mmdbresolve.Exe process on
    Windows.
    
    Bug: 15248
    Change-Id: Ic90cf438a8003a6fefb023b7056984681ce09b46
    Reviewed-on: https://code.wireshark.org/review/30449
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit bcaf997f8af1ac0c718140977d1b4f98a3321533)
    Reviewed-on: https://code.wireshark.org/review/30453
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  284422c   debian: install required GeoIP resolver executable and manual page
     add  a27b695   wsutil: introduce ws_pipe_close() helper and use it to terminate mmdbresolve


Summary of changes:
 capture_opts.c            |  2 +-
 debian/libwsutil9.symbols |  1 +
 epan/maxmind_db.c         |  3 +--
 extcap.c                  |  5 +----
 wsutil/ws_pipe.c          | 12 ++++++++++++
 wsutil/ws_pipe.h          |  6 ++++++
 6 files changed, 22 insertions(+), 7 deletions(-)