Wireshark-commits: [Wireshark-commits] master 4a2739e: Qt: fix saving exported objects after sortin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Oct 2018 09:39:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a2739ec88dff4c580ba51508a4cf3944718d09d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4a2739e by Moshe Kaplan (me@xxxxxxxxxxxxxxx):

    Qt: fix saving exported objects after sorting columns
    
    Avoid assuming an export object's row number is consistent throughout,
    because the row number can change if the display is filtered or sorted.
    Instead, look up the index in the model with mapToSource().
    
    Bug: 14545
    Change-Id: I61099dfb4f3abc056417eb7d6ffbc7a988553dd8
    Reviewed-on: https://code.wireshark.org/review/30388
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  da8e69e   docsis: Fixed reassembly for REG-REQ-MP and DBC-REQ MMMs
     add  4a2739e   Qt: fix saving exported objects after sorting columns


Summary of changes:
 ui/qt/export_object_dialog.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)