Wireshark-commits: [Wireshark-commits] master fa903e2: ldap: reflect the actual asn1 dissector to t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Oct 2018 19:57:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa903e2e03c96f5ed0dd34c9c363427a90fdcfbb
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fa903e2 by Dario Lombardo (lomato@xxxxxxxxx):

    ldap: reflect the actual asn1 dissector to the C version.
    
    Fix the build with newer gcc versions:
    
    ./epan/dissectors/packet-ldap.c
    ./asn1/ldap/ldap.cnf: In function ‘dissect_ldap_AttributeValue’:
    ./asn1/ldap/ldap.cnf:453:11: error: variable ‘len’ set but not used [-Werror=unused-but-set-variable]
    cc1: all warnings being treated as errors
    ninja: build stopped: subcommand failed.
    
    Change-Id: Id3a5369b4ca29f6989ab7b0bd652d72c239164a5
    Reviewed-on: https://code.wireshark.org/review/30313
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  39d79fc   appveyor: comment out artifacts upload due to size too large.
     add  fa903e2   ldap: reflect the actual asn1 dissector to the C version.


Summary of changes:
 epan/dissectors/packet-ldap.c | 63 +++++++++++++++++++++----------------------
 1 file changed, 30 insertions(+), 33 deletions(-)