Wireshark-commits: [Wireshark-commits] master e6e2137: cmake: rewrite FindGMODULE2.cmake and FindGT
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Oct 2018 20:05:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e6e2137459750cfac0b9ce7bcf259fe8bbccbede
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e6e2137 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: rewrite FindGMODULE2.cmake and FindGTHREAD2.cmake
    
    These modules currently set the library variables from PkgConfig
    directly, but these are not absolute paths. These modules are therefore
    not usable for static linking. Rewrite these files to follow a more
    familiar pattern: collect hints, find absolute header/library paths and
    let FPHSA handle the REQUIRED check.
    
    The old modules had some special cases for Apple, but I believe that
    these cases are no longer relevant.
    
    Change-Id: Idaef7e35b40a3ab4449d92ccb12a9febde962cf6
    Reviewed-on: https://code.wireshark.org/review/30251
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  021b305   CMake: limit the -pie linker option to executables
     add  e6e2137   cmake: rewrite FindGMODULE2.cmake and FindGTHREAD2.cmake


Summary of changes:
 cmake/modules/FindGMODULE2.cmake | 75 +++++++++++++++++-----------------------
 cmake/modules/FindGTHREAD2.cmake | 73 ++++++++++++++++++--------------------
 2 files changed, 65 insertions(+), 83 deletions(-)