Wireshark-commits: [Wireshark-commits] master f7596b8: Clean up MSVC version string generation.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2018 06:11:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7596b82ab99cc83a24451f1c6e2ebb8af156478
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f7596b8 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up MSVC version string generation.
    
    Don't bother with versions prior to VS 2010; as of Wireshark 2.4, we
    don't support them.
    
    Show it as "Visual Studio (year)", followed by the toolchain version
    (not to be confused with the compiler version - or with the Visual
    Studio version!).
    
    Do the same thing for the clang/C2 compiler; just append the clang
    version stuff after that.
    
    Indent the #if/#elif/#else/#endif to make it a little clearer how
    they're nested.
    
    Change-Id: Ib7a3af3251e6375d267b3b5da9f8e26a377ceeac
    Reviewed-on: https://code.wireshark.org/review/30138
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ec6ace0   DCOM: always NUL-terminate dissect_dcom_BSTR results
     add  f7596b8   Clean up MSVC version string generation.


Summary of changes:
 version_info.c | 192 ++++++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 129 insertions(+), 63 deletions(-)