Wireshark-commits: [Wireshark-commits] master-2.4 249f515: HTTP: ignore large Content-Length values
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 16:00:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=249f515fb0a98098588527fc21e5a8e5addb4d25
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

249f515 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: ignore large Content-Length values
    
    The SSTP capture from bug 8239 failed to be recognized as SSTP.  Its
    large Content-Length was parsed as -1 which triggered reassembly due to
    tvb_bytes_exist returning FALSE for negative lengths.
    
    Test:
    
        # Expect 'SSTP_DUPLEX_POST /' in the output of:
        tshark -r sstp.pcapng -ossl.keys_list:localhost,443,http,sstp.pem, -Y frame.number==174 -Px
    
    Change-Id: I40afaff8554f34f24e09bab184121ced59045954
    Fixes: v2.9.0rc0-531-gd80acae40d ("tvbuff: make tvb_bytes_exist fail with negative values")
    Reviewed-on: https://code.wireshark.org/review/29109
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 4802e3300dc18a973f74990d0d3f96068a7759d1)
    Reviewed-on: https://code.wireshark.org/review/30120
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  1900d9e   ftype-protocol: do not return from TRY/CATCH
     add  249f515   HTTP: ignore large Content-Length values


Summary of changes:
 epan/req_resp_hdrs.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)