Wireshark-commits: [Wireshark-commits] master 573e842: Windows: Make our program details more consi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 15:40:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=573e8420027377cce79750b85f416c3b9a740968
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

573e842 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Windows: Make our program details more consistent.
    
    Use a single template file for most of our program resources. Encode
    our resource files as UTF-8. Add resources to extcap/*.exe.
    
    Replace a regex with concatenation.
    
    Change-Id: I0ed49086618127ca4fdef69272f849d8f16e4dab
    Reviewed-on: https://code.wireshark.org/review/30088
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b7107f5   Diameter: add a few more AVPs from 3GPP 29.272 v15.5.0
     add  573e842   Windows: Make our program details more consistent.


Summary of changes:
 CMakeLists.txt                                | 72 ++++++++++++---------------
 cmake/modules/UseExecutableResources.cmake    | 26 ++++++++++
 extcap/CMakeLists.txt                         |  7 +++
 image/capinfos.rc.in                          | 36 --------------
 image/captype.rc.in                           | 36 --------------
 image/{text2pcap.rc.in => cli_template.rc.in} | 11 ++--
 image/dumpcap.rc.in                           |  3 +-
 image/editcap.rc.in                           | 36 --------------
 image/libwireshark.rc.in                      |  3 +-
 image/libwscodecs.rc.in                       |  3 +-
 image/libwsutil.rc.in                         |  3 +-
 image/mergecap.rc.in                          | 36 --------------
 image/rawshark.rc.in                          | 41 ---------------
 image/reordercap.rc.in                        | 36 --------------
 image/tfshark.rc.in                           | 41 ---------------
 image/tshark.rc.in                            |  3 +-
 image/wireshark.rc.in                         |  3 +-
 image/wiretap.rc.in                           |  3 +-
 18 files changed, 84 insertions(+), 315 deletions(-)
 create mode 100644 cmake/modules/UseExecutableResources.cmake
 delete mode 100644 image/capinfos.rc.in
 delete mode 100644 image/captype.rc.in
 rename image/{text2pcap.rc.in => cli_template.rc.in} (67%)
 delete mode 100644 image/editcap.rc.in
 delete mode 100644 image/mergecap.rc.in
 delete mode 100644 image/rawshark.rc.in
 delete mode 100644 image/reordercap.rc.in
 delete mode 100644 image/tfshark.rc.in