Wireshark-commits: [Wireshark-commits] master 1a9f074: OSITP: do not call subdissector if there is
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 04:04:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a9f074c0c03a1cfae6f63d183ae1791ac11b532
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1a9f074 by Peter Wu (peter@xxxxxxxxxxxxx):

    OSITP: do not call subdissector if there is no data
    
    None of the current heuristics dissectors for "cotp" accept the packet,
    so just skip calling subdissectors if the packet is empty.
    
    Change-Id: Ie26f05d472b4d184d5229ceab8b143a88cc921fc
    Reviewed-on: https://code.wireshark.org/review/30103
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Émilio Gonzalez <egg997@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8c31cdc   ftype-protocol: do not return from TRY/CATCH
     add  1a9f074   OSITP: do not call subdissector if there is no data


Summary of changes:
 epan/dissectors/packet-ositp.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)