Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 0a74a3b: Clean up some things.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a74a3b0391fa2603bd1b49be763461f8a7833e9
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

0a74a3b by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up some things.
    
    Rename ascend_seek() to ascend_find_next_packet(), to indicate what it
    does; it doesn't seek to an arbitrary place, it tries to find the
    starting offset of the next packet when reading sequentially.
    
    Don't have it set the header type - that's the job of the parser.
    
    Don't set the "next packet seek start" when doing random access I/O -
    that field is only for sequential I/O, and we don't want random I/O
    happening at the same time (which can happen in Wireshark) interfering.
    
    Clean up comments.
    
    Change-Id: I2808479eeec074afa16945ffb577b91d8cb356f7
    Reviewed-on: https://code.wireshark.org/review/29975
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f71f9684388c9112ac6c2b080fd59358203ebd21)
    Reviewed-on: https://code.wireshark.org/review/29977
    

Actions performed:

    from  647cc58   Don't return TRUE with *err or *err_info set.
     add  0a74a3b   Clean up some things.


Summary of changes:
 wiretap/ascend.y     |  4 ++--
 wiretap/ascendtext.c | 59 ++++++++++++++++++++++++++++++----------------------
 2 files changed, 36 insertions(+), 27 deletions(-)