Wireshark-commits: [Wireshark-commits] master-2.4 95bbf04: Fix handling of some ISDN calls.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 01 Oct 2018 20:02:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95bbf04d7e05e92bb988633c363c9096ed394f74
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

95bbf04 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of some ISDN calls.
    
    There's no guarantee that there will be two digits after PRI-XMIT or
    PRI-RCV; the capture file in bug 3535, for exmaple, has "PRI-XMIT-0/1"
    and "PRI-RCV-0".
    
    Require a minimum of 1, not 2, non-{/(:} characters.  Leave the maximum
    of 20 in place.
    
    Change-Id: Ie8f8f4ff5eb04baf0ee61bf28015e59a1fa43948
    Reviewed-on: https://code.wireshark.org/review/29947
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 5428e8ddbe92c80e28189be5039a49feee9d2242)
    Reviewed-on: https://code.wireshark.org/review/29966
    

Actions performed:

    from  04f796e   Show the *per-file* encapsulation in the __tostring method.
     add  95bbf04   Fix handling of some ISDN calls.


Summary of changes:
 wiretap/ascend_scanner.l | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)