Wireshark-commits: [Wireshark-commits] master 95cf63f: sharkd: cleanup printf() usage during JSON g
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Sep 2018 17:43:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95cf63f4d79740caa1350f4578ef0b4ac0fe929e
Submitter: "Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

95cf63f by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    sharkd: cleanup printf() usage during JSON generation (part I).
    
    Lower number of printf()s by adding some function wrappers.
    
    Replace:
      printf("]");   with  sharkd_json_array_close();
      printf("}");   with  sharkd_json_object_close();
      printf("\[");  with  sharkd_json_array_open();
      printf("{");   with  sharkd_json_object_open();
    
    These replaces lower number of printf() from 434 to 365 (15% reduction).
    
    Change-Id: I44f2244a7c1f8992a38c56c64759ed039aafaedc
    Reviewed-on: https://code.wireshark.org/review/29809
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    

Actions performed:

    from  4b4c119   RPM packaging: maxminddb is optional.
     add  95cf63f   sharkd: cleanup printf() usage during JSON generation (part I).


Summary of changes:
 sharkd_session.c | 170 +++++++++++++++++++++++++++++++------------------------
 1 file changed, 97 insertions(+), 73 deletions(-)