Wireshark-commits: [Wireshark-commits] master a76d4da: sharkd: Fix check request for empty "" filte
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Sep 2018 20:49:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a76d4da8bf1456156394e5660bf37e5fcd75238c
Submitter: "Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a76d4da by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    sharkd: Fix check request for empty "" filter
    
    For empty filters dfilter_compile() return success but with NULL dfcode.
    NULL dfcode cannot be used in dfilter_deprecated_tokens().
    
    Request: {"req":"check","filter":""} was crashing sharkd.
    
    Change-Id: Id677fc84251ab27bf691ec8aaee4c5bdf55e4d6c
    Reviewed-on: https://code.wireshark.org/review/29797
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    

Actions performed:

    from  58b24ed   FP: Fix Sub-Frame number dissection
     add  a76d4da   sharkd: Fix check request for empty "" filter


Summary of changes:
 sharkd_session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)