Wireshark-commits: [Wireshark-commits] master 557649f: TFTP: Use a GByteArray.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Sep 2018 12:33:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=557649fc566094c502fa5f475febde6fa2ef852e
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

557649f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    TFTP: Use a GByteArray.
    
    Replace the file_block_t struct with GByteArray.
    
    Change-Id: I95c2a92b91aa7248e45722b1d06dcb0cd6b1c0c3
    Reviewed-on: https://code.wireshark.org/review/29788
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  16e6cbf   rtp-ed137: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
     add  557649f   TFTP: Use a GByteArray.


Summary of changes:
 epan/dissectors/CMakeLists.txt |  1 -
 epan/dissectors/packet-tftp.c  | 35 ++++++++++++-----------------------
 epan/dissectors/packet-tftp.h  | 21 ---------------------
 3 files changed, 12 insertions(+), 45 deletions(-)
 delete mode 100644 epan/dissectors/packet-tftp.h