Wireshark-commits: [Wireshark-commits] master 1a63f1c: checkAPIs.pl: improve value_string validatio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 23:01:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a63f1ca9b7e8c24b9a20373bd28e82f7181c368
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1a63f1c by Peter Wu (peter@xxxxxxxxxxxxx):

    checkAPIs.pl: improve value_string validation in field definitions
    
    Use of 32-bit value_string for 64-bit fields currently results in a
    runtime error during use, better catch it earlier. Use of 64-bit
    val64_string without BASE_VAL64_STRING will probably crash.
    
    Since many dissectors use no macro for value_string_ext, accept both
    VALS_EXT_PTR(x) and &x forms.
    
    Change-Id: I59a3f67425e7c00bdd54cbffd91e498ee0b078cd
    Reviewed-on: https://code.wireshark.org/review/29756
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  54f106f   checkAPIs.pl: recognize fields with spaces in display
     add  1a63f1c   checkAPIs.pl: improve value_string validation in field definitions


Summary of changes:
 tools/checkAPIs.pl | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)