Wireshark-commits: [Wireshark-commits] master e8c6735: ospf: avoid BASE_EXT_STRING without strings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 05:04:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8c6735bcd3ee9b8119330df3bc9f71d87eb9dd1
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e8c6735 by Peter Wu (peter@xxxxxxxxxxxxx):

    ospf: avoid BASE_EXT_STRING without strings
    
    dissect_ospf_lsa_mpls uses gmpls_sonet_signal_type_str_ext to map the
    first byte, so do the same for the field definition. The function
    actually uses proto_tree_add_uint_format, so this does not make much of
    a difference though.
    
    Change-Id: Idba0c1b882ce81512bac221f98464f1322986fa8
    Fixes: v1.99.6rc0-12-g4afaad75d5 ("Remove proto_tree_add_text from packet-ospf.c")
    Reviewed-on: https://code.wireshark.org/review/29750
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4aad20b   ieee80211: fix potential crash due to value_string type mismatch
     add  e8c6735   ospf: avoid BASE_EXT_STRING without strings


Summary of changes:
 epan/dissectors/packet-ospf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)