Wireshark-commits: [Wireshark-commits] master 9de95b8: packet-rsl: Fix dissection of "CB Command Ty
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 17 Sep 2018 07:54:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9de95b83f87e49a5d99085df1e8aa262f4fa2af1
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9de95b8 by Harald Welte (laforge@xxxxxxxxxxxx):

    packet-rsl: Fix dissection of "CB Command Type" IE
    
    The "CB Command Type" IE is described in 3GPP TS 48.058 Section 9.3.41,
    and consists of three fields.  Prior to this patch, the dissector would
    decode none of them and instead produce a non-applicable "channel type"
    dissection.
    
    Change-Id: Ibb97432871df1276524fe96512ac1b67d5c5d3f0
    Reviewed-on: https://code.wireshark.org/review/29683
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1eb9860   NBAP: Remove #if 0'd code
     add  9de95b8   packet-rsl: Fix dissection of "CB Command Type" IE


Summary of changes:
 epan/dissectors/packet-rsl.c | 49 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)