Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 9bd645b: Do not use #if* in struct

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9bd645bbbc6073c710f1e0accc98366602423d05
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

9bd645b by Michał Łabędzki (michal.labedzki@xxxxxxxxxxxxx):

    Do not use #if* in struct
    
    Do not assume that somebody always includes "config.h" with "epan/prefs.h",
    because I do not include that one and I notice a lot of bugs, like:
    in one file sizeof(prefs) is 538 but in another is 544...
    and of course preferences do not work as expected - order of fields
    in the struct was changed. Try to avoid #if in struct.
    
    Remove dependency of config.h for prefs by removing #ifs, because all prefs
    should be registered also if not used.
    
    Change-Id: I02f71d2e64acf3e0f90c802b1610cc4620727051
    Reviewed-on: https://code.wireshark.org/review/27654
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit bded74eb669a5d1789c2ea876e0044db17fe61e2)
    Reviewed-on: https://code.wireshark.org/review/29541
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  adc9141   kafka: raise the required version to 1.5.0 for lz4_frame.
     add  9bd645b   Do not use #if* in struct


Summary of changes:
 epan/prefs.c | 7 -------
 epan/prefs.h | 4 ----
 2 files changed, 11 deletions(-)