Wireshark-commits: [Wireshark-commits] master-2.2 f783f47: Don't use on-the-stack buffers for pinfo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 08 Sep 2018 19:49:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f783f4731dff9109c3e2b925a177da16ed6bacdc
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.2
Repository: wireshark

Commits:

f783f47 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use on-the-stack buffers for pinfo addresses.
    
    pinfo addresses are supposed to be valid after the routine that sets
    them exits; therefore, the data mustn't be on the stack.
    
    Change-Id: I7db48065b2cacad200fa6b18e19b68e130e535a5
    Reviewed-on: https://code.wireshark.org/review/29492
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 8dd322ba98b15a8dd967d7714bbedf28c4a8edce)
    Reviewed-on: https://code.wireshark.org/review/29495
    

Actions performed:

    from  9b548c2   Add make-manuf.py to dist.
     add  f783f47   Don't use on-the-stack buffers for pinfo addresses.


Summary of changes:
 epan/dissectors/packet-bthci_sco.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)