Wireshark-commits: [Wireshark-commits] master 1bf2719: Proxy: fix heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Aug 2018 08:46:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1bf27192c90a10b947bff72ab9ab29426052cf9a
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1bf2719 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Proxy: fix heuristic dissector
    
    Ensure that at least 12 bytes were captured before trying to check the magic.
    Otherwise it can trigger an exception and prevent other heuristic dissectors
    from being called.
    
    Change-Id: Ib90febc208a69ae4e10c5c971e7cddfa7157c8a4
    Reviewed-on: https://code.wireshark.org/review/29298
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  281936a   SSL: use col_append_sep_str() to add heartbeat to info column
     add  1bf2719   Proxy: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-proxy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)