Wireshark-commits: [Wireshark-commits] master 7208f3a: OAMPDU: fix dissection of DPOE TLV
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Aug 2018 19:48:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7208f3a71cc8bcbf821a0fea5c61a512063d3e84
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7208f3a by Kevin A. Noll (kevinanoll@xxxxxxxxx):

    OAMPDU: fix dissection of DPOE TLV
    
    When dissecting a DPOE TLV, dissector incorrectly attempts to
    read a value when the value length is set to zero. This causes
    the dissector to throw a malformed packet error. Added a check
    for length zero and skip adding the value if length is zero.
    Created an expert info output indicating that the TLV value is
    zero length.
    
    Change-Id: I313e20f6f436b9f0af3e6f82044964fe7c502485
    Reviewed-on: https://code.wireshark.org/review/29270
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bc6d445   Fix EditorConfig keyword
     add  7208f3a   OAMPDU: fix dissection of DPOE TLV


Summary of changes:
 epan/dissectors/packet-oampdu.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)