Wireshark-commits: [Wireshark-commits] master-2.6 ecfea20: Fix the "Manage interfaces" dialog colum
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Aug 2018 22:27:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ecfea201653d8c9b323e58f9fa3e0ac4e39b4d05
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

ecfea20 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the "Manage interfaces" dialog columns.
    
    Windows is not the only OS with "friendly" names for interfaces; macOS
    has them as well, and some *BSDs let you tag interfaces with names as
    well.
    
    The column headings for the "Interface Name" and the "Friendly Name"
    were backwards.
    
    Change-Id: I72543505cec9d479d8ab8aab3850daab3667805f
    Reviewed-on: https://code.wireshark.org/review/29082
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit a1b3be58e1ad491ffe100fcf37607a1c1ccf7973)
    Reviewed-on: https://code.wireshark.org/review/29083
    

Actions performed:

    from  01e0bba   More comments.
     add  ecfea20   Fix the "Manage interfaces" dialog columns.


Summary of changes:
 ui/qt/manage_interfaces_dialog.cpp    | 2 --
 ui/qt/models/interface_tree_model.cpp | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)