Wireshark-commits: [Wireshark-commits] master 2d865f2: [GSM A RR]: fix APDU ID/Flags parsing for Ap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 04 Aug 2018 07:10:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d865f270848431817e8908e812d52f49ee68c8f
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d865f2 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    [GSM A RR]: fix APDU ID/Flags parsing for Application Info
    
    According to 3GPP TS 04.08, table 9.1.53.1, Application Information
    message has two mandatory fields encoded in a single octet:
    
      - APDU ID (section 10.5.2.48) M V 1/2,
      - APDU Flags (section 10.5.2.49) M V 1/2.
    
    For some reason, they were dissected incorrectly:
    
    GSM A-I/F DTAP - Application Information
      Protocol Discriminator: Radio Resources Management messages (6)
        .... 0110 = Protocol discriminator: Radio Resources Management messages (0x6)
        0000 .... = Skip Indicator: No indication of selected PLMN (0)
      DTAP Radio Resources Management Message Type: Application Information (0x38)
      APDU ID
        .... 0000 = APDU ID: RRLP (GSM 04.31) LCS (0x0)
      Missing Mandatory element APDU ID, rest of dissection is suspect
        [Expert Info (Error/Protocol): Missing Mandatory element APDU ID,
                                       rest of dissection is suspect]
        [Missing Mandatory element APDU ID, rest of dissection is suspect]
          [Severity level: Error]
          [Group: Protocol]
      APDU Flags
        0000 .... = APDU Flags: Unknown (0x0)
      APDU Data
        [...]
    
    Change-Id: Ibb248104289da8e602ac15da15ae9e8eadb42c42
    Reviewed-on: https://code.wireshark.org/review/28947
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  50e6046   RANAP: decrease the min length to 7 bytes
     add  2d865f2   [GSM A RR]: fix APDU ID/Flags parsing for Application Info


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)