Wireshark-commits: [Wireshark-commits] master 762f12d: GSM SIM: Fix special case for "Wrong length"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Jul 2018 20:44:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=762f12d625a3e4fe43a7d19d26b9e6de97dd90e2
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

762f12d by Darien Spencer (cusneud@xxxxxxxx):

    GSM SIM: Fix special case for "Wrong length" sw
    
    While TS 51.011 defines '67 XX' as "Incorrect param P3", TS 102.221 specifies
    a special case '67 00' which wasn't taken into account in the dissector
    
    Change-Id: I2f17bd0035b3a9f4cdd625523eef06be416d451e
    Reviewed-on: https://code.wireshark.org/review/28849
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  8607026   msgpack: replace pow() with shift.
    adds  762f12d   GSM SIM: Fix special case for "Wrong length" sw


Summary of changes:
 epan/dissectors/packet-gsm_sim.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)