Wireshark-commits: [Wireshark-commits] master 2cfa301: Qt: Create the main display filter combo soo
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Jul 2018 23:25:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cfa3013bc2890dd1ea8468366344c3d3878f3a0
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2cfa301 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Create the main display filter combo sooner.
    
    Construct MainWindow::df_combo_box_ in our initializer list, otherwise
    anything that triggers a resizeEvent early on might result in an NPE.
    
    Wait until everything is in place before calling setMinimumWidth.
    
    Bug: 14979
    Change-Id: I78b349f9c3ea53d8b1399a77169bbbd0a4a69191
    Reviewed-on: https://code.wireshark.org/review/28728
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  40d180e   Lua: add include/lua-5.1 and include/lua-5.2 to CMake path suffixes
    adds  2cfa301   Qt: Create the main display filter combo sooner.


Summary of changes:
 ui/qt/main_window.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)