Wireshark-commits: [Wireshark-commits] master 670377f: Don't show temporary file names in title bar
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=670377f491dd11bfe2b59738e9dfb329dbc826d4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
670377f by Guy Harris (guy@xxxxxxxxxxxx):
Don't show temporary file names in title bars.
For dialogs and auxiliary windows, if we have a live capture that hasn't
yet been saved to a permanent location, there's no good reason to show
the temporary file name in the title bar, as:
it's a random string that doesn't indicate where the capture was done
and that could confuse people (see, for example, the confusion in bug
14929, in which somebody referred to the "Follow TCP Stream" window as
the ".pcap dialog" because its title had ".pcap" at the end, due to
the capture file being a temporary file and its name showing up in the
title bar of that window);
it differs from what the main window title bar shows.
While we're at it, don't assume that the file name in the capture_file
structure is a UTF-8 string - some UN*Xes might not use UTF-8 for file
names.
Change-Id: I0d3dfd5d7f896ea37533daf7089b688710dbabf0
Reviewed-on: https://code.wireshark.org/review/28581
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 03200d9 packet-stcsig.c: Improve detection of false positives
adds 670377f Don't show temporary file names in title bars.
Summary of changes:
ui/qt/capture_file.cpp | 36 ++++++++++++++++++++++++++++++++++--
ui/qt/capture_file.h | 22 ++++++++++++++++++----
2 files changed, 52 insertions(+), 6 deletions(-)
