Wireshark-commits: [Wireshark-commits] master 1a8ed6f: Fix NFSv4.2 CHANGE_TYPE constants
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jun 2018 10:21:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a8ed6fa2807893c15c9220453bf1e59f47f4982
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a8ed6f by J. Bruce Fields (bfields@xxxxxxxxxxxx):

    Fix NFSv4.2 CHANGE_TYPE constants
    
    See https://tools.ietf.org/html/rfc7862#section-12.2.3
    
    As far as I can tell these were zero-based even in the earliest protocol
    drafts, so this was just a mistake in the original wireshark submission
    that nobody caught because change_attr_type hasn't been widely
    implemented.
    
    While we're here, move the defines before the array for better
    readability.
    
    Change-Id: Ie721250748fe77098aee4e2cc502ae43fc497a2d
    Reviewed-on: https://code.wireshark.org/review/28271
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2d4b50f   Put the entire server response into the Info column as is.
    adds  1a8ed6f   Fix NFSv4.2 CHANGE_TYPE constants


Summary of changes:
 epan/dissectors/packet-nfs.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)