Wireshark-commits: [Wireshark-commits] master 5ecbcaf: Improve the secondary error messages for pca
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Jun 2018 14:26:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ecbcaf483a552a8b78d525b9f32c5cfa575d59c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5ecbcaf by Guy Harris (guy@xxxxxxxxxxxx):

    Improve the secondary error messages for pcap errors.
    
    On Windows, if WinPcap isn't installed, warn about that for errors other
    than failed attempts to start capturing.
    
    On HP-UX, if we appear to have an old version of libpcap, warn about
    that for errors other than failed attempts to start capturing.
    
    If we know the error is a permissions problem, don't make suggestions
    appropriate to other problems.
    
    If we know the error is *not* a permissions problem, don't make
    suggestions appropriate to permissions problems.
    
    For permissions problems, or possible permissions problems, on Linux,
    suggest doing dpkg-reconfigure wireshark-common if you've installed from
    a package on Debian or a Debian derivative such as Ubuntu.
    
    Change-Id: If4aac0343095ac0b984eebc21853920c3b6d3c63
    Ping-Bug: 14847
    Reviewed-on: https://code.wireshark.org/review/28189
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e0b8837   [Automatic update for 2018-06-10]
    adds  5ecbcaf   Improve the secondary error messages for pcap errors.


Summary of changes:
 caputils/capture-pcap-util-int.h  |  13 +-
 caputils/capture-pcap-util-unix.c |  15 ++-
 caputils/capture-pcap-util.c      | 272 ++++++++++++++++++++++----------------
 caputils/capture-pcap-util.h      |  13 +-
 caputils/capture-wpcap.c          |  12 +-
 dumpcap.c                         | 167 ++++++++++++++---------
 6 files changed, 299 insertions(+), 193 deletions(-)