Wireshark-commits: [Wireshark-commits] master-2.4 baa51c1: Make sure proto_tree_add_expert items ar
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 06 Jun 2018 16:35:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=baa51c1b2f8d185d45b2e0fd0459ae0202450480
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

baa51c1 by Guy Harris (guy@xxxxxxxxxxxx):

    Make sure proto_tree_add_expert items are always added to the tree.
    
    Make sure that proto_tree_add_text_internal() and
    proto_tree_add_text_valist_internal() don't throw an exception, so the
    indication always appears in the tree to indicate the issue.  Do the
    "do the bytes exist" check *after* we've added all of the expert info to
    the protocol tree, so we still throw the appropriate exception.
    
    Change-Id: I4e0d2dcc48f9c8f4482550ae16284b9e021232cd
    Reviewed-on: https://code.wireshark.org/review/28062
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f2dada066344924b754ea30569c05adce0c4e9dc)
    Reviewed-on: https://code.wireshark.org/review/28064
    

Actions performed:

    from  e885dd8   3GPP NAS: fix dissection of Linked TI IE
    adds  baa51c1   Make sure proto_tree_add_expert items are always added to the tree.


Summary of changes:
 epan/expert.c | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)