Wireshark-commits: [Wireshark-commits] master 79b12ab: Use proper unsigned constant for bit shift
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Jun 2018 09:18:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79b12ab0713f6d7b6ce536f9ce1382f6901914e0
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

79b12ab by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Use proper unsigned constant for bit shift
    
    Shifting (signed) '1' 31 bits is undefined. Make it unsigned.
    
    Change-Id: Iff300493907c53b47bb116a0282846955e0f2429
    Signed-off-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/27981
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4af2344   Send the "Command and args:" message to the right output file.
    adds  79b12ab   Use proper unsigned constant for bit shift


Summary of changes:
 wiretap/k12.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)