Wireshark-commits: [Wireshark-commits] master-2.2 9a5370e: Debugging for bug 14738.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Jun 2018 01:05:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a5370e7a9676be6fef81e7796e867858c01d9d6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

9a5370e by Guy Harris (guy@xxxxxxxxxxxx):

    Debugging for bug 14738.
    
    In the loop that adds fields, make sure that the packet offset never
    stays the same or goes backwards.
    
    Change-Id: I2645a85856d4d31ed91d5e779b025cbfe24c6b5a
    Ping-Bug: 14738
    Reviewed-on: https://code.wireshark.org/review/27938
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 4d676afbb73a69e908bc3a15512201c10d09aa8f)
    Reviewed-on: https://code.wireshark.org/review/27939
    

Actions performed:

    from  614d523   Don't check the CRC if the message isn't big enough to have a CRC.
    adds  9a5370e   Debugging for bug 14738.


Summary of changes:
 epan/dissectors/packet-mmse.c | 43 +++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)