Wireshark · Wireshark-commits: [Wireshark-commits] master 2cb6056: http: continue parsing in spite of illegal header name

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cb6056388404130c3590e2871d2fe8ea23d3710
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2cb6056 by Peter Wu (peter@xxxxxxxxxxxxx):

    http: continue parsing in spite of illegal header name
    
    While HTTP header names are restricted to a limited set, many
    implementations basically read whole lines and then look for a colon.
    Actual validation happens after that. Follow that approach to avoid
    early termination of request/response headers and diagnose the issue.
    
    This may break HTTP/0.9 response parsing, but nobody should be using
    that now.
    
    Bug: 10123
    Change-Id: If435aa832effc83095f9b6b822a76cb46451e7de
    Reviewed-on: https://code.wireshark.org/review/27605
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Craig Jackson <cejackson51@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  635cad9   mstp: fix buffer overflow in COBS decoding
    adds  2cb6056   http: continue parsing in spite of illegal header name


Summary of changes:
 epan/dissectors/packet-http.c | 106 ++++++++++++++++++------------------------
 1 file changed, 46 insertions(+), 60 deletions(-)