Wireshark-commits: [Wireshark-commits] master-2.6 46e2816: RPC-over-RDMA: fix infinite loop
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 May 2018 16:01:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46e28166a01d2007ad839ea1195c741664179e13
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

46e2816 by Peter Wu (peter@xxxxxxxxxxxxx):

    RPC-over-RDMA: fix infinite loop
    
    When there are two segments, but zero requests, "i=1" will be reset to
    "i=0" and an infinite loop occurs.
    
    Change-Id: I32cb387ce0724936bcb5d5832b1c90d2bc585998
    Fixes: v2.5.2rc0-100-g8f0f691312 ("RPC-over-RDMA: add reassembly for reply, read and write chunks")
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7138
    Reviewed-on: https://code.wireshark.org/review/27891
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit d2671e6b6ac3557dc605cd0e32e45eca2858a440)
    Reviewed-on: https://code.wireshark.org/review/27898
    

Actions performed:

    from  abcfec4   Qt: select a better default Decode As table
    adds  46e2816   RPC-over-RDMA: fix infinite loop


Summary of changes:
 epan/dissectors/packet-rpcrdma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)